Skip to content

chore(site): remove build logs from experimental #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2023
Merged

chore(site): remove build logs from experimental #8619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
badb8e9
chore(site): remove build logs from experimental
BrunoQuaresma Jul 20, 2023
6991289
Merge branch 'main' into bq/remove-build-logs-experiment
BrunoQuaresma Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions coderd/apidoc/docs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions coderd/apidoc/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions codersdk/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,8 +1805,6 @@ const (
// WARNING: This cannot be enabled when using HA.
ExperimentSingleTailnet Experiment = "single_tailnet"

ExperimentWorkspaceBuildLogsUI Experiment = "workspace_build_logs_ui"

// ExperimentTemplateRestartRequirement allows template admins to have more
// control over when workspaces created on a template are required to
// restart, and allows users to ensure these restarts never happen during
Expand All @@ -1827,9 +1825,7 @@ const (
// users to opt-in to via --experimental='*'.
// Experiments that are not ready for consumption by all users should
// not be included here and will be essentially hidden.
var ExperimentsAll = Experiments{
ExperimentWorkspaceBuildLogsUI,
}
var ExperimentsAll = Experiments{}

// Experiments is a list of experiments that are enabled for the deployment.
// Multiple experiments may be enabled at the same time.
Expand Down
1 change: 0 additions & 1 deletion docs/api/schemas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2585,7 +2585,6 @@ AuthorizationObject can represent a "set" of objects, such as: all workspaces in
| `tailnet_ha_coordinator` |
| `convert-to-oidc` |
| `single_tailnet` |
| `workspace_build_logs_ui` |
| `template_restart_requirement` |

## codersdk.Feature
Expand Down
2 changes: 0 additions & 2 deletions site/src/api/typesGenerated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,15 +1466,13 @@ export type Experiment =
| "tailnet_ha_coordinator"
| "template_restart_requirement"
| "workspace_actions"
| "workspace_build_logs_ui"
export const Experiments: Experiment[] = [
"convert-to-oidc",
"moons",
"single_tailnet",
"tailnet_ha_coordinator",
"template_restart_requirement",
"workspace_actions",
"workspace_build_logs_ui",
]

// From codersdk/deployment.go
Expand Down
8 changes: 3 additions & 5 deletions site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,11 @@ export const WorkspaceReadyPage = ({
const user = useMe()
const { isWarningIgnored, ignoreWarning } = useIgnoreWarnings(user.id)
const buildLogs = useBuildLogs(workspace)
const dashboard = useDashboard()
const shouldDisplayBuildLogs =
hasJobError(workspace) ||
(dashboard.experiments.includes("workspace_build_logs_ui") &&
["canceling", "deleting", "pending", "starting", "stopping"].includes(
workspace.latest_build.status,
))
["canceling", "deleting", "pending", "starting", "stopping"].includes(
workspace.latest_build.status,
)
const {
mutate: restartWorkspace,
error: restartBuildError,
Expand Down