feat: Add Section component #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 65.81% 65.79% -0.02%
==========================================
Files 202 207 +5
Lines 13209 13333 +124
Branches 87 94 +7
==========================================
+ Hits 8693 8773 +80
- Misses 3626 3663 +37
- Partials 890 897 +7
Continue to review full report at Codecov.
|
presleyp
reviewed
Apr 4, 2022
| )} | ||
| {description && typeof description !== "string" && ( | ||
| <div className={styles.description}>{description}</div> | ||
| )} |
presleyp
reviewed
Apr 4, 2022
| children: ( | ||
| <form style={{ display: "grid", gridAutoFlow: "row", gap: 12 }}> | ||
| <TextField label="Name" variant="filled" fullWidth /> | ||
| <TextField label="Email" variant="filled" fullWidth /> |
There was a problem hiding this comment.
Could you give an example of using Section.Action?
There was a problem hiding this comment.
I added it inside of the children props because it is just a wrapper component and maybe it is too much to add a separate storybook for it. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #658