ci: fmt, lint and build offlinedocs #8642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows linting offlinedocs with `make lint` and `make lint/ts`
make lint/tsmake lint/ts
make lint/tsmake lint/ts
make lint/tsmake lint/ts
deansheather
approved these changes
Jul 21, 2023
make lint/tsmake lint/ts and make fmt
deansheather
previously approved these changes
Jul 21, 2023
make lint/ts and make fmtmake lint/ts and make fmt
make lint/ts and make fmt
matifali
commented
Jul 24, 2023
matifali
commented
Jul 24, 2023
| @@ -35,6 +35,8 @@ jobs: | |||
| ts: ${{ steps.filter.outputs.ts }} | |||
| k8s: ${{ steps.filter.outputs.k8s }} | |||
| ci: ${{ steps.filter.outputs.ci }} | |||
| offlinedocs-only: ${{ steps.filter.outputs.offlinedocs_count == steps.filter.outputs.all_count }} | |||
| offlinedocs: ${{ steps.filter.outputs.offlinedocs }} | |||
There was a problem hiding this comment.
This will skip lint and format when we only target offlinedocs.
lint and fmt checks do not check offline docs so this was useless here
deansheather
approved these changes
Jul 24, 2023
.github/workflows/ci.yaml
Outdated
| - name: Build | ||
| run: | | ||
| version="$(./scripts/version.sh)" | ||
| yarn global add prettier # Install prettier before running the script |
There was a problem hiding this comment.
Is this line necessary? You already install it globally above
Co-authored-by: Dean Sheather <dean@deansheather.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt, lint and build offlinedocs.