Skip to content

chore: update nix flake to include sqlc v1.19.0 #8645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

chore: update nix flake to include sqlc v1.19.0 #8645

merged 1 commit into from
Jul 21, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 21, 2023 •
edited
Loading

Spotted in #8644

make gen is failing on Mac with the following complain:

make gen
generate
models.go:16:2: no required module provides package github.com/tabbed/pqtype; to add it:
	go get github.com/tabbed/pqtype
make: *** [Makefile:506: coderd/database/querier.go] Error 1
make: *** Deleting file 'coderd/database/querier.go'

I presume that we have to update the dependency on sqlc to v1.19.

@mtojek mtojek self-assigned this Jul 21, 2023
@mtojek mtojek requested review from johnstcn and mafredri July 21, 2023 12:18
@mtojek mtojek marked this pull request as ready for review July 21, 2023 12:19
mafredri
mafredri approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exactly v1.19.0? Any chance we can make it v1.19.1 instead, or is that not available yet?

@mtojek
Copy link
Member Author

mtojek commented Jul 21, 2023

Unfortunately not, the last merged one is v1.19.0.

@mtojek mtojek merged commit c8772fb into main Jul 21, 2023
@mtojek mtojek deleted the nix-update-sqlc-1.19 branch July 21, 2023 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri