Skip to content

chore: do not deploy a PR on deleted comment #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2023
Merged

chore: do not deploy a PR on deleted comment #8677

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
201122e
chore: improve deploy-pr.yaml
matifali Jul 23, 2023
13188e7
Update pr-deploy.yaml
matifali Jul 23, 2023
ada950d
make fmt
matifali Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pr-deploy.yaml
  • Loading branch information
@matifali
matifali authored Jul 23, 2023
commit 13188e7be424f96810e7769f51f1c5769d5373d2
4 changes: 2 additions & 2 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,14 @@ jobs:
mkdir -p ~/.kube
echo "${{ secrets.DELIVERYBOT_KUBECONFIG }}" > ~/.kube/config
export KUBECONFIG=~/.kube/config

- name: Create PR namespace
run: |
set -euxo pipefail
# try to delete the namespace, but don't fail if it doesn't exist
kubectl delete namespace "pr${{ env.PR_NUMBER }}" || true
kubectl create namespace "pr${{ env.PR_NUMBER }}"

- name: Install Helm chart
run: |
helm upgrade --install pr${{ env.PR_NUMBER }} ./helm \
Expand Down