feat(cli): add --var shorthand for --variable #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b554c9e to
12ae951
Compare
ericpaulsen
approved these changes
Jul 25, 2023
|
thx @ericpaulsen I'll hold off on merging this until @mtojek gives the 👍🏽 on the flag name. |
mtojek
approved these changes
Jul 25, 2023
cli/templatecreate.go
Outdated
| Flag: "variable", | ||
| Description: "Specify a set of values for Terraform-managed variables.", | ||
| Value: clibase.StringArrayOf(&variables), | ||
| FlagShorthand: "V", |
There was a problem hiding this comment.
-V is always confusing as it usually means --version or --verbose.
Maybe we should another alias, -var, instead? Alternatively, we can add support for TF_VAR_.
`--variable` is used frequently enough to deserve a shorthand. Unfortunately, `-v` is taken by verbose, and `-V` is too easily confused with version or verbose, so we're left with "--var".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(cli): add --var shorthand for --variable
--variableis used frequently enough to deserve a shorthand. Unfortunately,-vis taken by verbose, and-Vis too easily confused with version orverbose, so we're left with "--var".