Skip to content

test: improve pr deployments #8720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 25, 2023
Merged

test: improve pr deployments #8720

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc39420
set up custom domain
matifali Jul 25, 2023
f89ee84
prepare for Github OAuth
matifali Jul 25, 2023
c8b1799
Merge remote-tracking branch 'origin/main' into matifai/prdeploymnets
matifali Jul 25, 2023
d3dfa35
WIP
matifali Jul 25, 2023
f41901a
Merge remote-tracking branch 'origin/main' into matifai/prdeploymnets
matifali Jul 25, 2023
df9be79
fix typo
matifali Jul 25, 2023
7382ee3
update Ingress
matifali Jul 25, 2023
03981fa
fix Ingress and wildcard
matifali Jul 25, 2023
5c18f3d
update KUBECONFIG secret name
matifali Jul 25, 2023
b5ece69
Enable experiments
matifali Jul 25, 2023
ba8e3ac
update comments
matifali Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable experiments
  • Loading branch information
@matifali
matifali committed Jul 25, 2023
commit b5ece697e2b47fd0bfd2f766bf7e469d653326e7
20 changes: 11 additions & 9 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,16 +197,18 @@ jobs:
--set coder.env[0].value="pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \
--set coder.env[1].name=CODER_WILDCARD_ACCESS_URL \
--set coder.env[1].value="*--pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \
--set coder.env[2].name=CODER_EXPERIMENTS \
--set coder.env[2].value="*" \
# Uncomment this when https://github.com/coder/coder/issues/8714 is resolved
# --set coder.env[2].name=CODER_OAUTH2_GITHUB_ALLOW_SIGNUPS \
# --set coder.env[2].value=true \
# --set coder.env[3].name=CODER_OAUTH2_GITHUB_CLIENT_ID \
# --set coder.env[3].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_ID }} \
# --set coder.env[4].name=CODER_OAUTH2_GITHUB_CLIENT_SECRET \
# --set coder.env[4].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_SECRET }} \
# --set coder.env[5].name=CODER_OAUTH2_GITHUB_ALLOWED_ORGS \
# --set coder.env[5].value=coder \
# --set coder.env[6].name=CODER_OAUTH2_GITHUB_REDIRECT_URI \
# --set coder.env[3].name=CODER_OAUTH2_GITHUB_ALLOW_SIGNUPS \
# --set coder.env[3].value=true \
# --set coder.env[4].name=CODER_OAUTH2_GITHUB_CLIENT_ID \
# --set coder.env[4].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_ID }} \
# --set coder.env[5].name=CODER_OAUTH2_GITHUB_CLIENT_SECRET \
# --set coder.env[5].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_SECRET }} \
# --set coder.env[6].name=CODER_OAUTH2_GITHUB_ALLOWED_ORGS \
# --set coder.env[6].value=coder \
# --set coder.env[7].name=CODER_OAUTH2_GITHUB_REDIRECT_URI \
# --set coder.env[7].value="https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}/gitauth/github/callback \
--force

Expand Down