feat(site): add template insights page #8722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma could you please post some screenshots? |
|
@mtojek I posted a video! |
mtojek
approved these changes
Jul 26, 2023
| @@ -1862,7 +1865,9 @@ const ( | |||
| // users to opt-in to via --experimental='*'. | |||
| // Experiments that are not ready for consumption by all users should | |||
| // not be included here and will be essentially hidden. | |||
| var ExperimentsAll = Experiments{} | |||
| var ExperimentsAll = Experiments{ | |||
| ExperimentTemplateInsightsPage, | |||
There was a problem hiding this comment.
Is it intended to release as experimental?
There was a problem hiding this comment.
Yes, I talked with @bpmct about this
| @@ -1,37 +0,0 @@ | |||
| import { render } from "testHelpers/renderHelpers" | |||
There was a problem hiding this comment.
Yeap, it is just a render test which should be on the storybook.
| } | ||
| } | ||
|
|
||
| function sevenDaysAgo() { |
There was a problem hiding this comment.
This is a good one. I don't think a "week ago" is a good name for this because you are at Wed and a week ago would be the previous week from Mon to Fri so 7 days ago is different and for this case would be more accurate
| @@ -3506,6 +3506,11 @@ | |||
| "@types/connect" "*" | |||
| "@types/node" "*" | |||
|
|
|||
| "@types/chroma-js@2.4.0": | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8689
Demo:
Screen.Recording.2023-07-25.at.13.49.09.mov
Next steps: