Skip to content

ci: improve deploy-pr workflow #8735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jul 27, 2023
Merged

ci: improve deploy-pr workflow #8735

merged 53 commits into from
Jul 27, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 26, 2023

This PR changes the following behavior.

  • 1. Set coder.image.pullPolicy=Always (otherwise, we always deploy the image from the first deployment of the PR)
  • 2. Use the Helm chart from the current branch (we can test the Helm chart, too, @ericpaulsen )
  • 3. Comment deployment link on the last comment
  • 4. Comment deployment URL.
  • 5. Remove serviceAccount.enableDeployments=true as this is the default
  • 6. Enable GitHub OAuth
  • 7. Automatically create the first user (I guess it's not needed if we have GitHub OAuth and allow signups)
  • 8. Test everything works (the most difficult part)
  • 9. Add a script to deploy a PR from CLI (e.g.) (./scripts/deploy-pr.sh)
  • 10. Allows skipping build the image with --skip-build flag

cc: @bpmct

@matifali matifali requested a review from bpmct July 26, 2023 08:26
@matifali matifali changed the title ci: set image pull policy to always for PR deployments ci: improve deploy-pr workflow Jul 26, 2023
@bpmct
Copy link
Member

bpmct commented Jul 26, 2023

@matifali looks like we still need to make the first user. perhaps we use a random password and hide it from stdout.

@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@coder coder deleted a comment from github-actions bot Jul 27, 2023
@matifali matifali enabled auto-merge (squash) July 27, 2023 09:54
@matifali matifali disabled auto-merge July 27, 2023 09:55
@matifali matifali changed the title ci: improve deploy-pr workflow ci: improve deploy-pr workflow Jul 27, 2023
@matifali matifali merged commit bc55ffd into main Jul 27, 2023
@matifali matifali deleted the fix-deploy-pr branch July 27, 2023 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants