Skip to content

chore(scripts): use fake semver when using sapling #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore(scripts): use fake semver when using sapling #8747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(scripts): use fake semver when using sapling 
The fact that the Sapling commit didn't conform to semver
broke the agent handshake with coderd.
  • Loading branch information
@ammario
ammario committed Jul 26, 2023
commit 50b8154235b6205843d91c8dc24d15095027c315
2 changes: 1 addition & 1 deletion scripts/version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cdroot

# If in Sapling, just print the commit since we don't have tags.
if [ -d ".sl" ]; then
sl log -l 1 | awk '/changeset/ { print substr($2, 0, 16) }'
sl log -l 1 | awk '/changeset/ { printf "0.0.0+sl-%s\n", substr($2, 0, 16) }'
exit 0
fi

Expand Down