Skip to content

chore: upgrade nodejs version to 18.x #8768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 27, 2023
Merged

chore: upgrade nodejs version to 18.x #8768

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7bbea72
chore: update nodejs version to 18.x
BrunoQuaresma Jul 27, 2023
cb12e52
Remove unecessary file
BrunoQuaresma Jul 27, 2023
b15bbfa
Merge branch 'main' into bq/upgrade-nodejs
matifali Jul 27, 2023
18ca39e
Fix fmt
BrunoQuaresma Jul 27, 2023
90c5394
Update deps
BrunoQuaresma Jul 27, 2023
8f101a8
Merge branch 'main' into bq/upgrade-nodejs
BrunoQuaresma Jul 27, 2023
c1e5eee
Fix e2e tests
BrunoQuaresma Jul 27, 2023
1d831f7
Merge branch 'main' into bq/upgrade-nodejs
BrunoQuaresma Jul 27, 2023
2587104
Fix deps
BrunoQuaresma Jul 27, 2023
5e7eecd
Fix timeout
BrunoQuaresma Jul 27, 2023
9c53a2d
Fix lint types
BrunoQuaresma Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix timeout
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jul 27, 2023
commit 5e7eecd86cc95d4d40843060d9d4cec2714833a4
4 changes: 2 additions & 2 deletions site/src/components/DeploymentBanner/DeploymentBannerView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ export const DeploymentBannerView: FC<DeploymentBannerViewProps> = ({
let canceled = false
const loop = () => {
if (canceled) {
return
return undefined
}
setTimeUntilRefresh(timeUntilRefresh--)
if (timeUntilRefresh > 0) {
return setTimeout(loop, 1000)
return window.setTimeout(loop, 1000)
}
fetchStats()
}
Expand Down