Skip to content

ci: use a wildcard subdomain for PR deployments #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 1, 2023
Merged

ci: use a wildcard subdomain for PR deployments #8801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0f00e25
wip
matifali Jul 27, 2023
0093621
fmt
matifali Jul 30, 2023
f3f6669
fix binary path
matifali Jul 30, 2023
198c429
fix
matifali Jul 30, 2023
6bd5c80
fix info in slack notification
matifali Jul 30, 2023
27f37ce
run in subshell
matifali Jul 30, 2023
41c9d70
fix credentials output
matifali Jul 30, 2023
e76c683
change username
matifali Jul 30, 2023
2e74a83
Merge branch 'main' into use-wildcard-domain
matifali Jul 30, 2023
67858e4
Update pr-cleanup.yaml
matifali Jul 30, 2023
e526434
Typo
matifali Jul 30, 2023
1fbf9ff
use subshells
matifali Jul 30, 2023
5ed660e
allow custom experiments
matifali Jul 30, 2023
b1e9663
handle extra experiments
matifali Jul 30, 2023
382ecca
handle concurrency
matifali Jul 30, 2023
7ad2857
update
matifali Jul 30, 2023
81cf4c3
fixup
matifali Jul 30, 2023
48d8871
add experiments flag
matifali Jul 30, 2023
af9b588
wip
matifali Jul 30, 2023
bc881dc
use coder ingress
matifali Jul 31, 2023
dac8997
fix EOF
matifali Jul 31, 2023
c9daeaf
fix lint
matifali Jul 31, 2023
8192128
double quotes
matifali Jul 31, 2023
3e6d936
store secret in a shared namespace
matifali Aug 1, 2023
5ade8b7
sanitize secret
matifali Aug 1, 2023
176a78d
use subshell
matifali Aug 1, 2023
86f22d1
url encoding
matifali Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle extra experiments
  • Loading branch information
@matifali
matifali committed Jul 30, 2023
commit b1e966338357b73f9ae7eb97885685720e740e66
7 changes: 2 additions & 5 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,7 @@ jobs:
if [[ ${{ github.event_name }} == "workflow_dispatch" ]]; then
experiments=${{ github.event.inputs.experiments }}
else
experiments=$(echo "${{ github.event.comment.body }}" | grep -oP '(?<=--experiments ).*')
if [ -z "$experiments" ]; then
experiments="*"
fi
experiments=$(echo "${{ github.event.comment.body }}" | grep -oP '(?<=--experiments )[^ ]+')
fi
echo "experiments=$experiments" >> $GITHUB_OUTPUT

Expand All @@ -266,7 +263,7 @@ jobs:
- name: "CODER_WILDCARD_ACCESS_URL"
value: "*.${{ env.PR_DEPLOYMENT_ACCESS_URL }}"
- name: "CODER_EXPERIMENTS"
value: "${{ steps.get_experiments.outputs.experiments }}"
value: "*,${{ steps.get_experiments.outputs.experiments }}"
- name: CODER_PG_CONNECTION_URL
valueFrom:
secretKeyRef:
Expand Down
5 changes: 5 additions & 0 deletions scripts/deploy-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,9 @@ if $dryRun; then
exit 0
fi

echo "branchName: ${branchName}"
echo "prNumber: ${prNumber}"
echo "skipBuild: ${skipBuild}"
echo "experiments: ${experiments}"

gh workflow run pr-deploy.yaml --ref "${branchName}" -f "pr_number=${prNumber}" -f "skip_build=${skipBuild}"