fix(scripts): check if PR list is empty #8805
Conversation
|
I have accidentally pushed to the wrong branch. |
|
@phorcys420 you need to run |
|
I pushed the wrong files, lol. |
Thanks Atif, I think it should maybe be added to the Contributing docs. |
There was a problem hiding this comment.
Could you share a bit about your use-case and why you need to call the commit metadata script on a branch?
I think this change could be fine, although the previous behavior is a bit safer in that we may not want to continue if the gh command doesn't return any output (since we don't know if it guarantees a proper exit code).
Then again, the previous behavior might fail in an edge case where we only want to release a single commit that wasn't merged via PR.
|
hey @mafredi, I am looking at making the release action work (atleast mostly) in a branch that way you can do dry-runs in a fork. The idea is that it would allow for easier testing (in the real environment that it would run in) when PRing stuff like Chocolatey or Scoop support. This would allow you to find out for simple syntax errors and other simple things you might not see by eye. |
|
Alright, thanks for expanding on that. Let's get this merged and hopefully unblock you! |
I am currently (= finally) working on a PR for chocolatey support.
During testing, It occured to me that the release notes were always failing, that is because
check_commit_metadata.shtries to loop over$pr_metadata_raweven if it is empty, this causes an issue because PRs don't ususally have PRs.This PR makes it so that it checks if the PR list is empty before looping.