Skip to content

feat: add version to footer #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Apr 7, 2022
Merged

feat: add version to footer #882

merged 24 commits into from
Apr 7, 2022

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Apr 5, 2022 •
edited
Loading

version

@code-asher code-asher requested a review from a team as a code owner April 5, 2022 23:43
code-asher
code-asher commented Apr 5, 2022
View reviewed changes
code-asher
code-asher commented Apr 5, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #882 (adfea9e) into main (2e5859f) will decrease coverage by 0.04%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   66.04%   66.00%   -0.05%     
==========================================
  Files         218      220       +2     
  Lines       13849    13890      +41     
  Branches      103      105       +2     
==========================================
+ Hits         9147     9168      +21     
- Misses       3783     3796      +13     
- Partials      919      926       +7
Flag Coverage Δ
unittest-go-macos-latest 52.81% <70.00%> (+0.03%) ⬆️
unittest-go-postgres- 65.80% <70.00%> (-0.12%) ⬇️
unittest-go-ubuntu-latest 55.35% <70.00%> (+0.01%) ⬆️
unittest-go-windows-2022 52.26% <70.00%> (+0.06%) ⬆️
unittest-js 59.74% <91.66%> (+0.64%) ⬆️
Impacted Files Coverage Δ
buildinfo/buildinfo.go 56.09% <ø> (ø)
cli/root.go 76.41% <ø> (ø)
codersdk/buildinfo.go 50.00% <50.00%> (ø)
site/src/xServices/buildInfo/buildInfoXService.ts 71.42% <71.42%> (ø)
coderd/coderd.go 97.02% <100.00%> (+0.14%) ⬆️
site/src/api/index.ts 72.41% <100.00%> (+3.18%) ⬆️
site/src/components/Page/Footer.tsx 100.00% <100.00%> (ø)
site/src/test_helpers/entities.ts 100.00% <100.00%> (ø)
site/src/test_helpers/handlers.ts 28.00% <100.00%> (+6.26%) ⬆️
site/src/xServices/StateContext.tsx 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5859f...adfea9e. Read the comment docs.

kylecarbs
kylecarbs requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go side looks good to me. Just a few minor things! 😎

@code-asher code-asher marked this pull request as draft April 6, 2022 00:17
@code-asher
Copy link
Member Author

code-asher commented Apr 6, 2022 •
edited
Loading

Moving to a draft since I neglected to update the frontend footer test.

@code-asher
Add frontend mock for buildinfo route
0479d34
@code-asher
Sort BuildInfoResponse alphabetically
123d523 
The rest of the file is not alphabetic but might as well.
@code-asher code-asher marked this pull request as ready for review April 6, 2022 00:32
kylecarbs
kylecarbs reviewed Apr 6, 2022
View reviewed changes
greyscaled
greyscaled reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Had some fairly low-key suggestions around conditionally rendering and using a function to construct the version string; nothing major.

Am going to look out for @presleyp 's review to see if there's any suggestions on the xService or global context 🙌🏻 .

code-asher
code-asher commented Apr 6, 2022
View reviewed changes
site/src/components/Page/Footer.test.tsx Outdated
@@ -1,7 +1,7 @@
import { screen } from "@testing-library/react"
import React from "react"
import { MockBuildInfo, render } from "../../test_helpers"
import { Footer } from "./Footer"
import { render, MockBuildInfo } from "../../test_helpers"
Copy link
Member Author

@code-asher code-asher Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear render and MockBuildInfo keep shuffling on their own but that seems impossible. 👽

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I empathize with this feeling

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#876

@code-asher code-asher requested a review from kylecarbs April 6, 2022 17:24
kylecarbs
kylecarbs approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice change.

@code-asher
Merge remote-tracking branch 'origin/main' into asher/footer
d540e09
@code-asher
Run make fmt
228ab5e 
Looks like one line got one character too long after the merge.
greyscaled
greyscaled suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge latest main into this branch so that we get the Chromatic workflow to run

@code-asher code-asher requested a review from greyscaled April 7, 2022 00:09
greyscaled
greyscaled approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

presleyp
presleyp reviewed Apr 7, 2022
View reviewed changes
presleyp
presleyp reviewed Apr 7, 2022
View reviewed changes
presleyp
presleyp reviewed Apr 7, 2022
View reviewed changes
presleyp
presleyp reviewed Apr 7, 2022
View reviewed changes
@code-asher code-asher merged commit 1859579 into main Apr 7, 2022
@code-asher code-asher deleted the asher/footer branch April 7, 2022 17:19
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@greyscaled greyscaled greyscaled approved these changes

@presleyp presleyp presleyp approved these changes

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
5 participants
@code-asher @presleyp @kylecarbs @greyscaled @misskniss