Skip to content

ci: build and push ghcr.io/coder/coder-preview:main #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Aug 1, 2023

Build and push a docker image with the tag ghcr.io/coder/coder-preview:main on each commit merged to the main.
We average merging 10-20 PRs daily, so I am avoiding creating an commit-sha tag.

@matifali matifali requested review from bpmct and johnstcn August 1, 2023 12:56
@matifali matifali changed the title ci: build edge docker image ci: build and push edge tag Aug 1, 2023
@bpmct
Copy link
Member

bpmct commented Aug 1, 2023

Where is the edge tag specified? This looks like it pushes to latest.

@bpmct
Copy link
Member

bpmct commented Aug 1, 2023

Also, may I suggest we publish these to coder/coder-preview to avoid any accidental conflicts? Plus they can be auto-cleaned up?

@matifali
Copy link
Member Author

matifali commented Aug 1, 2023

@bpmct It will be just one tag edge that will be replaced on each commit to main
Ok, I am open to moving it to ghcr.io/coder/coder-preview:edge

Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifali
Copy link
Member Author

matifali commented Aug 2, 2023

@bpmct should I move it to ghcr.io/coder/coder-preview:edge or using ghcr.io/coder/coder:edge is fine?

@matifali matifali changed the title ci: build and push edge tag ci: build and push ghcr.io/coder/coder-preview:edge Aug 2, 2023
@matifali matifali changed the title ci: build and push ghcr.io/coder/coder-preview:edge ci: build and push ghcr.io/coder/coder-preview:main Aug 2, 2023
@matifali
Copy link
Member Author

matifali commented Aug 2, 2023

OK. Changing it to ghcr.io/coder/coder-preview:main as it points to the main branch.

move pkg from `ghcr.io/coder/coder:edge` to `ghcr.io/coder/coder-preview:main`
@matifali matifali merged commit 57c7d7d into main Aug 2, 2023
@matifali matifali deleted the build-edge-image branch August 2, 2023 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants