feat(site): Add Admin Dropdown menu #885
Conversation
Codecov Report
@@ Coverage Diff @@
## main #885 +/- ##
==========================================
+ Coverage 65.92% 66.10% +0.17%
==========================================
Files 228 238 +10
Lines 14126 14221 +95
Branches 105 115 +10
==========================================
+ Hits 9313 9401 +88
Misses 3868 3868
- Partials 945 952 +7
Continue to review full report at Codecov.
|
|
So far on the backend we've removed a ton of settings in the "Admin UI" in favor of flags on the coder start command. At this time I can't think of any settings we'll need for MVP, so it seems fine to leave it off for now. I know Github Oauth will land on settings, but I think that's officially "not MVP". I think any work toward the page itself is fine, because we will probably need one eventually, but I wouldn't prioritize the work or link to it yet. |
|
Can you merge latest main into this branch so that we get the Chromatic workflow to run |
| @@ -0,0 +1,26 @@ | |||
| import { fade, makeStyles, Theme } from "@material-ui/core/styles" | |||
There was a problem hiding this comment.
I like how much more reusable these arrows are now.
| path={entry.path} | ||
| title={entry.label} | ||
| variant="narrow" | ||
| onClick={() => { |
There was a problem hiding this comment.
This is not something we need to address here but just a thought I had. I think all of the dropdown items as they exist in v1 could easily be NavLinks so I wonder if we should remove the ability to pass in an onClick and make path required. Maybe that would promote making sure nav items really are regular anchor-based nav items, too (in v1 trying to open "add organization" in a new tab by middle-mouse clicking for example does nothing because it utilizes onClick for page navigation instead of being a standard <a>).
There was a problem hiding this comment.
Sounds like a good idea, can you make a chore ticket for it?
If reaching a decision takes a bit maybe we merge with it in and remove later if necessary (or the other way around works too I suppose). |
Fixes #591
Adds BorderedMenu, BorderedMenuRow, Typography from v1
Adds AdminDropdown, based on v1 ManageDropdown
extracts OpenDropdown and CloseDropdown - arrows we can reuse in dropdowns
some reorganization of files and storybook
stories for BorderedMenu (which includes BorderedMenuRow), Typography, and AdminDropdown
test for AdminDropdown - currently just testing links, wrote a ticket to add and test that only admins see it but I don't think we have that capability yet. It's currently guarded by whether you are literally
admin@coder.com😂add AuthAndNav to routes
remove Settings?Tyler says to keep it