Skip to content

fix: trim scope of agent private key route #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Apr 6, 2022

No description provided.

@f0ssel f0ssel requested a review from kylecarbs April 6, 2022 14:42
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #886 (7e5c04d) into main (9da17be) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   65.73%   65.63%   -0.11%     
==========================================
  Files         216      216              
  Lines       13736    13733       -3     
  Branches      103      103              
==========================================
- Hits         9030     9013      -17     
- Misses       3787     3795       +8     
- Partials      919      925       +6     
Flag Coverage Δ
unittest-go- 65.45% <ø> (-0.01%) ⬇️
unittest-go-macos-latest 52.58% <ø> (-0.30%) ⬇️
unittest-go-ubuntu-latest 55.33% <ø> (+<0.01%) ⬆️
unittest-go-windows-2022 52.07% <ø> (-0.07%) ⬇️
unittest-js 58.83% <ø> (ø)
Impacted Files Coverage Δ
coderd/gitsshkey.go 44.82% <ø> (-1.84%) ⬇️
codersdk/gitsshkey.go 50.00% <ø> (ø)
coderd/database/db.go 55.17% <0.00%> (-13.80%) ⬇️
coderd/workspaceresources.go 54.87% <0.00%> (-6.10%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/conn.go 79.18% <0.00%> (-1.53%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
provisionerd/provisionerd.go 79.73% <0.00%> (ø)
coderd/provisionerdaemons.go 61.55% <0.00%> (+1.51%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da17be...7e5c04d. Read the comment docs.

@f0ssel f0ssel enabled auto-merge (squash) April 6, 2022 14:45
@f0ssel f0ssel merged commit 32759a8 into main Apr 6, 2022
@f0ssel f0ssel deleted the f0ssel/trim-privatekey branch April 6, 2022 14:54
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants