Skip to content

docs: reword latency explanation for HA #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

docs: reword latency explanation for HA #8860

merged 1 commit into from
Aug 15, 2023

Conversation

spikecurtis
Copy link
Contributor

Removes references to a specific latency time, and instead explains what Coderd is doing that requires low-latency.

Signed-off-by: Spike Curtis <spike@coder.com>
to each other so that they can effectively relay traffic between users and workspaces no
matter which Coderd instance users or workspaces connect to. We make a best-effort attempt
to warn the user when inter-Coderd latency is too high, but if requests start dropping, this
is one metric to investigate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: note specific metrics, link to https://coder.com/docs/v2/latest/admin/prometheus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we expose this over Prometheus... @kylecarbs ?

@spikecurtis spikecurtis changed the title Reword latency docs for HA docs: Reword latency explanation for HA Aug 3, 2023
@spikecurtis spikecurtis changed the title docs: Reword latency explanation for HA docs: reword latency explanation for HA Aug 3, 2023
For Coder to operate correctly, Coderd instances should have low-latency connections
to each other so that they can effectively relay traffic between users and workspaces no
matter which Coderd instance users or workspaces connect to. We make a best-effort attempt
to warn the user when inter-Coderd latency is too high, but if requests start dropping, this
Copy link
Member

@bpmct bpmct Aug 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we consider "too high" for the health check? We might as well document this threshold as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not sure what this is referring to. @kylecarbs do you know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpmct this text is not being changed by this PR, just whitespace. I understand the desire to get better documentation around the health check, but it's scope creep for this PR. Can we agree on whether or not the changes this PR is making are appropriate so it can get merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I misunderstood it as a text change.

@spikecurtis spikecurtis requested a review from bpmct August 10, 2023 04:46
@spikecurtis spikecurtis merged commit 63278ab into main Aug 15, 2023
@spikecurtis spikecurtis deleted the spike/docs-10ms branch August 15, 2023 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants