Skip to content

fix(site): fix initial value for update parameters #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(site): fix initial value for update parameters #8863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(site): fix initial value for update parameters
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Aug 2, 2023
commit 0e151c33af08711367fbd322bfdf84b7c1004449
11 changes: 8 additions & 3 deletions site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { useFormik } from "formik"
import {
selectInitialRichParametersValues,
useValidationSchemaForRichParameters,
workspaceBuildParameterValue,
} from "utils/richParameters"
import * as Yup from "yup"
import DialogActions from "@mui/material/DialogActions"
Expand All @@ -32,10 +33,11 @@ export const UpdateBuildParametersDialog: FC<
UpdateBuildParametersDialogProps
> = ({ missedParameters, onUpdate, ...dialogProps }) => {
const styles = useStyles()
const initialRichParameterValues =
selectInitialRichParametersValues(missedParameters)
const form = useFormik({
initialValues: {
rich_parameter_values:
selectInitialRichParametersValues(missedParameters),
rich_parameter_values: initialRichParameterValues,
},
validationSchema: Yup.object({
rich_parameter_values: useValidationSchemaForRichParameters(
Expand Down Expand Up @@ -81,9 +83,12 @@ export const UpdateBuildParametersDialog: FC<
{...getFieldHelpers(
"rich_parameter_values[" + index + "].value",
)}
initialValue={workspaceBuildParameterValue(
initialRichParameterValues,
parameter,
)}
key={parameter.name}
parameter={parameter}
initialValue=""
index={index}
onChange={async (value) => {
await form.setFieldValue(
Expand Down