Skip to content

ci: implement automatic upgrade of PR deployment #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Aug 3, 2023
Merged

ci: implement automatic upgrade of PR deployment #8876

merged 33 commits into from
Aug 3, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Aug 3, 2023 •
edited
Loading

  1. This will auto-update the PR deployment when new commits to the PR branch exist.
  2. This also intelligently checks if the image needs to be built again.
  3. will redeploy by using previous values
  4. remove deploying via issue_comment
  5. You can deploy the action manually or via ./scripts/deploy-pr.sh
  6. Updates contributing.md

@matifali matifali requested a review from bpmct August 3, 2023 08:53
@matifali matifali changed the title ci: auto update pr deployment ci: implement automatic update of PR deployment Aug 3, 2023
@coder coder deleted a comment from github-actions bot Aug 3, 2023
@coder coder deleted a comment from github-actions bot Aug 3, 2023
@coder coder deleted a comment from github-actions bot Aug 3, 2023
@coder coder deleted a comment from github-actions bot Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited
Loading

✔️ PR 8876 Updated successfully.
🚀 Access the credentials here.

cc: @matifali

matifali added 5 commits August 3, 2023 13:42
@matifali
tag actor
397f274
@matifali
move out of highlight
4874f0b
@matifali
update docs
f9b6635
@matifali
do not redeploy if there is no new build
384ff98
@matifali
only delete certificate if PR is merged
dae82bd 
This will prevent deleting the certificate for a PR if its is closed by stale bot and may be opened again.
@matifali matifali requested a review from johnstcn August 3, 2023 14:26
@johnstcn
Copy link
Member

johnstcn commented Aug 3, 2023

cc @deansheather

@matifali matifali requested a review from deansheather August 3, 2023 14:35
@matifali matifali changed the title ci: implement automatic update of PR deployment ci: implement automatic ugrade of PR deployment Aug 3, 2023
@matifali matifali changed the title ci: implement automatic ugrade of PR deployment ci: implement automatic upgrade of PR deployment Aug 3, 2023
@matifali matifali merged commit b47bd7c into main Aug 3, 2023
@matifali matifali deleted the auto-deploy-pr branch August 3, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn left review comments

@deansheather deansheather deansheather approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @johnstcn @deansheather