-
Notifications
You must be signed in to change notification settings - Fork 887
feat: add auto group create from OIDC #8884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a regex filter to filter out groups that are not important
coadler
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
With OIDC group sync, you can now have Coder automatically create the missing groups.
Closes #8214
Config options
CODER_OIDC_GROUP_AUTO_CREATE=true
This turns on the feature. By default groups are not created (previous behavior).
CODER_OIDC_GROUP_REGEX_FILTER=.*
This allow filtering out groups after the group rename mapping is applied. This is added because if groups are auto created, it is reasonable to assume users might want to omit some groups. A regex pattern does not cover all cases, but is a common filter method in OIDC providers.
Note that this filter can and should be applied in the OIDC provider. So supporting extensive group filtering options should not be done in Coder.
Group Changes
I added a
source
column onGroups
to tell the UI/User where the group came from. Right now the options areuser
for user created groups, andoidc
for groups created by the OIDC group sync.I think this could be helpful for anyone managing their coder instance wondering where these groups come from. I am not adding this in the UI atm since this PR size is already quite large.