Skip to content

feat: add auto group create from OIDC #8884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 8, 2023
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 3, 2023

What this does

With OIDC group sync, you can now have Coder automatically create the missing groups.

Closes #8214

Config options

CODER_OIDC_GROUP_AUTO_CREATE=true

This turns on the feature. By default groups are not created (previous behavior).

CODER_OIDC_GROUP_REGEX_FILTER=.*

This allow filtering out groups after the group rename mapping is applied. This is added because if groups are auto created, it is reasonable to assume users might want to omit some groups. A regex pattern does not cover all cases, but is a common filter method in OIDC providers.

Note that this filter can and should be applied in the OIDC provider. So supporting extensive group filtering options should not be done in Coder.

Group Changes

I added a source column on Groups to tell the UI/User where the group came from. Right now the options are user for user created groups, and oidc for groups created by the OIDC group sync.

I think this could be helpful for anyone managing their coder instance wondering where these groups come from. I am not adding this in the UI atm since this PR size is already quite large.

@Emyrk Emyrk marked this pull request as ready for review August 4, 2023 15:29
@Emyrk Emyrk requested a review from coadler August 7, 2023 14:35
@Emyrk Emyrk merged commit f4122fa into main Aug 8, 2023
@Emyrk Emyrk deleted the stevenmasley/group_auto_sync branch August 8, 2023 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groups: auto-create all groups sent from OIDC groups claim
2 participants