Skip to content

feat(cli): provide parameter values via command line #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 9, 2023
Merged

feat(cli): provide parameter values via command line #8898

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
30e99a5
Use rich parameter flags
mtojek Aug 4, 2023
61e9785
WIP
mtojek Aug 4, 2023
5d5e588
make update-golden-files
mtojek Aug 4, 2023
f739c8d
make gen
mtojek Aug 4, 2023
e622f4f
fix
mtojek Aug 4, 2023
c8cbfe1
Build options
mtojek Aug 4, 2023
f340dae
Pull build options from command line
mtojek Aug 4, 2023
4a96845
refactor
mtojek Aug 4, 2023
29d0eab
rename
mtojek Aug 4, 2023
9af782c
fixes
mtojek Aug 4, 2023
17bc078
Merge branch 'main' into 8782-build-option
mtojek Aug 7, 2023
db15c67
Merge branch 'main' into 8782-build-option
mtojek Aug 8, 2023
34c71bf
WIP
mtojek Aug 8, 2023
fd79380
fix
mtojek Aug 8, 2023
6e854a3
verifyConstraints
mtojek Aug 8, 2023
751fcf3
Fix?
mtojek Aug 8, 2023
c1aeae0
Resolver implemented
mtojek Aug 8, 2023
91d601d
revent: cli stat
mtojek Aug 8, 2023
9e05ce6
Fix: restart, create
mtojek Aug 8, 2023
f18d320
fix
mtojek Aug 8, 2023
47d4dd6
fix lint
mtojek Aug 8, 2023
2a903d8
Fix: old OptionalParameterAdded
mtojek Aug 8, 2023
66ce556
info
mtojek Aug 8, 2023
5763ef2
Fix: lint
mtojek Aug 8, 2023
eedeed6
Merge branch 'main' into 8782-build-option
mtojek Aug 8, 2023
02a6b1d
naming convention
mtojek Aug 8, 2023
177127c
More fixes
mtojek Aug 8, 2023
1fbc594
Merge branch 'main' into 8782-build-option
mtojek Aug 9, 2023
0f1b564
and cannot
mtojek Aug 9, 2023
7c5a520
more formal
mtojek Aug 9, 2023
2e017b4
more formal
mtojek Aug 9, 2023
1d4c0e0
start_test.go
mtojek Aug 9, 2023
34016f4
update_test.go
mtojek Aug 9, 2023
1d23f09
restart_test.go
mtojek Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix: lint
  • Loading branch information
@mtojek
mtojek committed Aug 8, 2023
commit 5763ef2db37c8e7644533de47d6049a35b5953a5
1 change: 0 additions & 1 deletion cli/parameter_resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ func (pr *ParameterResolver) resolveWithInput(resolved []codersdk.WorkspaceBuild
(action == WorkspaceUpdate && !tvp.Mutable && firstTimeUse) ||
(action == WorkspaceUpdate && tvp.Mutable && !tvp.Ephemeral && pr.promptRichParameters) ||
(action == WorkspaceCreate && !tvp.Ephemeral) {

parameterValue, err := cliui.RichParameter(inv, tvp)
if err != nil {
return nil, err
Expand Down