Skip to content

chore: rename .yml to .yaml #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2022
Merged

chore: rename .yml to .yaml #895

merged 2 commits into from
Apr 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 6, 2022 •
edited
Loading

I noticed an inconsistency in our choice of .yml vs .yaml. Based on feedback from the team, I chose to rename all files to use .yaml.

This means we'll keep it consistent in the codebase.

@jsjoeio jsjoeio self-assigned this Apr 6, 2022
@jsjoeio jsjoeio requested a review from a team as a code owner April 6, 2022 20:32
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #895 (cf6afb6) into main (fe23dcd) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   65.77%   65.82%   +0.05%     
==========================================
  Files         216      123      -93     
  Lines       13734    12570    -1164     
  Branches      103        0     -103     
==========================================
- Hits         9033     8274     -759     
+ Misses       3782     3406     -376     
+ Partials      919      890      -29
Flag Coverage Δ
unittest-go- 65.20% <ø> (-0.35%) ⬇️
unittest-go-macos-latest 52.80% <ø> (-0.20%) ⬇️
unittest-go-ubuntu-latest 55.27% <ø> (-0.08%) ⬇️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
cli/configssh.go 50.00% <0.00%> (-8.04%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
coderd/workspaceresources.go 54.87% <0.00%> (-5.70%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 56.36% <0.00%> (-3.64%) ⬇️
peer/conn.go 77.91% <0.00%> (-3.05%) ⬇️
peer/channel.go 83.04% <0.00%> (-2.93%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 79.14% <0.00%> (-1.62%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe23dcd...cf6afb6. Read the comment docs.

@code-asher
Copy link
Member

Oh yeah, we went with .yaml because that is the official extension. IMO that means we should stick with .yaml.

@code-asher
Copy link
Member

I should clarify by "we" I meant code-server, I got confused which repo I was on. I would still vote for .yaml here though!

@kylecarbs
Copy link
Member

I'm also a vote for .yaml! .yml doesn't read properly IMO

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Apr 6, 2022

Sounds good to me. I was hoping y'all wanted that. I prefer .yaml too. I'll make the change!

@jsjoeio jsjoeio requested review from code-asher and kylecarbs April 6, 2022 21:26
kylecarbs
kylecarbs approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the consistency!

@jsjoeio jsjoeio enabled auto-merge (squash) April 6, 2022 21:29
@jsjoeio jsjoeio merged commit eefca43 into main Apr 6, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-yml branch April 6, 2022 21:33
@greyscaled greyscaled changed the title chore: rename .yaml to .yml chore: rename .yml to .yaml Apr 6, 2022
@greyscaled
Copy link
Contributor

@jsjoeio I updated the title post-merge. We might want to double check the commit that was pushed to mainline, since it might accidentally convey the opposite 😂.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Apr 6, 2022

Oh no! I completely forgot to change 🤦🏼‍♂️ @vapurrmaid nice catch

@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
5 participants
@jsjoeio @code-asher @kylecarbs @greyscaled @misskniss