feat: update workspace deadline when template policy changes #8964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Aug 14, 2023
Comment on lines
+144
to
+149
| if s.UseRestartRequirement.Load() { | ||
| err = s.updateWorkspaceBuilds(ctx, db, template) | ||
| if err != nil { | ||
| return xerrors.Errorf("update workspace builds: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
How long can this take if there are a lot of workspaces?
There was a problem hiding this comment.
It's a few queries for each workspace, multiple selects and then an update. I don't think it will take very long, even with thousands of workspaces this should take less than a few seconds. I'll add instrumentation though
Emyrk
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the max deadline for the latest build (if it's the "start" transition) for each workspace using a template when the template changes it's policy.
Recalculate the max deadline using the job's completed_at time as "now" and apply it to the workspace build. If it's before
now() + 2hthen set the max deadline tonow() + 2h. If the existing deadline exceeds the new max deadline, set it to the max deadline.This only happens when the template policy changes, not when the user changes their quiet hours (to avoid gaming the system, they will need to restart workspaces for the new quiet hours to apply).
Closes #8837