Skip to content

chore: fix ruleguard xerrors rules #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023
Merged

chore: fix ruleguard xerrors rules #8967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0782d6
chore: fix ruleguard xerrors rules
deansheather Aug 8, 2023
afb11e2
fixup! chore: fix ruleguard xerrors rules
deansheather Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/stat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ func (*RootCmd) statDisk(s *clistat.Statter) *clibase.Cmd {
ds, err := s.Disk(pfx, pathArg)
if err != nil {
if os.IsNotExist(err) {
// fmt.Errorf produces a more concise error.
//nolint:gocritic // fmt.Errorf produces a more concise error.
return fmt.Errorf("not found: %q", pathArg)
}
return err
Expand Down
8 changes: 6 additions & 2 deletions scripts/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,12 @@ func xerrors(m dsl.Matcher) {
m.Import("fmt")
m.Import("golang.org/x/xerrors")

m.Match("fmt.Errorf($*args)").
Suggest("xerrors.New($args)").
m.Match("fmt.Errorf($arg)").
Suggest("xerrors.New($arg)").
Report("Use xerrors to provide additional stacktrace information!")

m.Match("fmt.Errorf($arg1, $*args)").
Suggest("xerrors.Errorf($arg1, $args)").
Report("Use xerrors to provide additional stacktrace information!")

m.Match("errors.$_($msg)").
Expand Down