Skip to content

feat(site): add date range picker for the template insights #8976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen.Recording.2023-08-08.at.11.32.09.mov

Close #8788

@BrunoQuaresma BrunoQuaresma requested a review from mafredri August 8, 2023 14:35
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 8, 2023
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM!

PS. Should we add a test for it as well? I don't think we need to test the component very thoroughly but having it select a range and confirm the correct request is made might he good.

@BrunoQuaresma BrunoQuaresma merged commit 76b1594 into main Aug 8, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/add-datepicker-range branch August 8, 2023 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement custom date picker for Insights
2 participants