Skip to content

chore: show basic experiment set value #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

chore: show basic experiment set value #8984

merged 1 commit into from
Aug 8, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 8, 2023 •
edited
Loading

This value is pre-parsed, meaning the experiments listed may not be valid. This is a very basic display for helping debuging purposes.

Closes: #8978 (comment)

When an experiment is enabled

Screenshot from 2023-08-08 13-51-04

When none are enabled

Screenshot from 2023-08-08 13-52-40

@Emyrk
chore: show basic experiment set value
39453c4 
This value is pre-parsed, meaning the experiments listed may not
be valid. This is a very basic display for helping debuging purposes.
@Emyrk Emyrk requested a review from matifali August 8, 2023 18:53
matifali
matifali approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Emyrk. I think it serves the purpose for the must have. Let us keep the issue open for now if we want to do nice to haves too later in future.
We will close if we don't plan to do them.

@Emyrk
Copy link
Member Author

Emyrk commented Aug 8, 2023

Thanks @Emyrk. I think it serves the purpose for the must have. Let us keep the issue open for now if we want to do nice to haves too later in future. We will close if we don't plan to do them.

Sounds good!

@Emyrk Emyrk merged commit d4e115d into main Aug 8, 2023
@Emyrk Emyrk deleted the stevenmasley/show_experiments branch August 8, 2023 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: List all enabled and available experiments on the deployment page
2 participants
@Emyrk @matifali