Skip to content

feat: add support for NodePort service type in Helm chart #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2023
Merged

feat: add support for NodePort service type in Helm chart #8993

merged 5 commits into from
Aug 11, 2023

Conversation

ffais
Copy link
Contributor

@ffais ffais commented Aug 9, 2023

Allow user to set nodePort value via values file, if service type is NodePort.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ffais ffais changed the title helm: add support for NodePort service type in Helm chart feat: add support for NodePort service type in Helm chart Aug 9, 2023
@ffais
Copy link
Contributor Author

ffais commented Aug 9, 2023

I have read the CLA Document and I hereby sign the CLA

@ffais
Copy link
Contributor Author

ffais commented Aug 9, 2023

recheck

cdrcommunity added a commit to coder/cla that referenced this pull request Aug 9, 2023
@kylecarbs kylecarbs requested a review from ericpaulsen August 9, 2023 16:15
@ericpaulsen ericpaulsen merged commit 6fd5344 into coder:main Aug 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants