Skip to content

chore: use echo provisioners in logging tests #9008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

chore: use echo provisioners in logging tests #9008

merged 2 commits into from
Aug 9, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Aug 9, 2023

They don't need any provisioning anyways.

@coadler coadler added the hotfix PRs only. Harmless small change. Only humans may set this. label Aug 9, 2023
@coadler coadler self-assigned this Aug 9, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Aug 9, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@coadler coadler enabled auto-merge (squash) August 9, 2023 18:51
@coadler coadler merged commit 612f1c6 into main Aug 9, 2023
@coadler coadler deleted the colin/log-test-use-echo branch August 9, 2023 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@coadler coadler

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coadler