Skip to content

fix(site): fix storybook error and inconsistent snapshots #9010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2023
Merged

fix(site): fix storybook error and inconsistent snapshots #9010

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c88966
fix(site): general settings storybook
BrunoQuaresma Aug 9, 2023
0e23001
Ignore fix width on storybook
BrunoQuaresma Aug 9, 2023
09a3792
Avoid auto scrolling on storybook
BrunoQuaresma Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid auto scrolling on storybook
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Aug 9, 2023
commit 09a3792d7ac868b6929363b159b1c49cec4d4413
5 changes: 5 additions & 0 deletions site/src/pages/WorkspacePage/WorkspaceBuildLogsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ export const WorkspaceBuildLogsSection = ({
const scrollRef = useRef<HTMLDivElement>(null)

useEffect(() => {
// Auto scrolling makes hard to snapshot test using Chromatic
if (process.env.STORYBOOK === "true") {
return
}

const scrollEl = scrollRef.current
if (scrollEl) {
scrollEl.scrollTop = scrollEl.scrollHeight
Expand Down