Skip to content

refactor(cli): adjust parameter resolver #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2023
Merged

refactor(cli): adjust parameter resolver #9019

merged 2 commits into from
Aug 10, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Aug 10, 2023 •
edited
Loading

Related: #8898

This PR addresses feedback from the previous review:

  • replace len(pr.buildOptions) == 0 with "not find exact build option"
  • replace goto with continue

@mtojek mtojek self-assigned this Aug 10, 2023
@mtojek mtojek mentioned this pull request Aug 10, 2023
Merged
@mtojek mtojek requested a review from mafredri August 10, 2023 09:49
@mtojek mtojek marked this pull request as ready for review August 10, 2023 09:49
mafredri
mafredri approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mtojek mtojek merged commit 9d9814c into main Aug 10, 2023
@mtojek mtojek deleted the fix-cli-parameter branch August 10, 2023 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri