feat: add terminationGracePeriodSeconds to provisioner chart #9048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
johnstcn
reviewed
Aug 14, 2023
| shutdown, shutdownCancel := context.WithTimeout(ctx, time.Minute) | ||
| defer shutdownCancel() | ||
| err = srv.Shutdown(shutdown) | ||
| err = srv.Shutdown(ctx) |
There was a problem hiding this comment.
What effect will this have outside of a Kubernetes environment if we have a build in progress that just hangs indefinitely?
There was a problem hiding this comment.
It will do what we describe earlier in this file:
"Interrupt caught, gracefully exiting. Use ctrl+\\ to force quit", that is, we'll wait indefinitely until we get a more aggressive signal like SIGQUIT (ctrl + \) or SIGKILL.
johnstcn
approved these changes
Aug 14, 2023
…isioner-helm-termination
Signed-off-by: Spike Curtis <spike@coder.com>
…isioner-helm-termination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help avoid killing builds when redeploying provisioner daemon via the Helm chart.