Skip to content

fix: prevent unrequested PR deployments #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2023
Merged

fix: prevent unrequested PR deployments #9049

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0319285
fix: fix deploying PRs on each push
matifali Aug 11, 2023
ede5b6d
fix syntax
matifali Aug 11, 2023
27241f0
fixup!
matifali Aug 11, 2023
29525e9
fixup!
matifali Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix syntax
  • Loading branch information
@matifali
matifali committed Aug 11, 2023
commit ede5b6d8da436891da1cf73ed0b54e878a6a518e
16 changes: 4 additions & 12 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ jobs:
CODER_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}
NEW: ${{ steps.check_deployment.outputs.NEW }}
BUILD: |
${{
(steps.filter.outputs.all_count > steps.filter.outputs.ignored_count ||
${{
(steps.filter.outputs.all_count > steps.filter.outputs.ignored_count ||
github.event.inputs.build == 'true') &&
(github.event_name == 'push' ||
steps.check_deployment.outputs.NEW == 'true')
Expand Down Expand Up @@ -171,20 +171,12 @@ jobs:
echo "CODER_BASE_IMAGE_TAG=${{ steps.set_tags.outputs.CODER_BASE_IMAGE_TAG }}"
echo "CODER_IMAGE_TAG=${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}"
echo "NEW=${{ steps.check_deployment.outputs.NEW }}"
echo "BUILD= /
${{ /
(steps.filter.outputs.all_count > steps.filter.outputs.ignored_count || /
github.event.inputs.build == 'true') && /
(github.event_name == 'push' || /
steps.check_deployment.outputs.NEW == 'true') /
}}
echo "BUILD=${{ (steps.filter.outputs.all_count > steps.filter.outputs.ignored_count || github.event.inputs.build == 'true') && (github.event_name == 'push' || steps.check_deployment.outputs.NEW == 'true') }}
echo "GITHUB_REF=${{ github.ref }}"

comment-pr:
needs: [check_pr, get_info]
if: |
(needs.get_info.outputs.BUILD == 'true' || github.event.inputs.deploy == 'true') &&
(github.event.
if: needs.get_info.outputs.BUILD == 'true' || github.event.inputs.deploy == 'true'
runs-on: "ubuntu-latest"
steps:
- name: Find Comment
Expand Down