Skip to content

feat: add header-process flag #9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

feat: add header-process flag #9059

merged 3 commits into from
Aug 14, 2023

Conversation

code-asher
Copy link
Member

This allows specifying a command to run that can output headers for cases where users require dynamic headers (like to authenticate to their VPN).

The primary use case is to add this flag in SSH configs created by the VS Code plugin, although maybe config-ssh should do the same.

This is required to complete coder/vscode-coder#119, which in turn is meant to close coder/vscode-coder#76.

@code-asher code-asher changed the title Add header-process flag feat: add header-process flag Aug 11, 2023
@code-asher code-asher force-pushed the asher/header-process branch 5 times, most recently from c763cee to 538d2fc Compare August 11, 2023 23:28
This allows specifying a command to run that can output headers for
cases where users require dynamic headers (like to authenticate to their
VPN).

The primary use case is to add this flag in SSH configs created by the
VS Code plugin, although maybe config-ssh should do the same.
@code-asher code-asher force-pushed the asher/header-process branch from 538d2fc to bccc2d6 Compare August 11, 2023 23:36
@code-asher code-asher marked this pull request as ready for review August 11, 2023 23:55
@code-asher
Copy link
Member Author

code-asher commented Aug 11, 2023

@kylecarbs just fyi I went with --header-process. If anyone has different name ideas I would love to hear them! Or if anyone thinks this should be more generic to potentially supply more than just headers in the future.

@code-asher code-asher force-pushed the asher/header-process branch 3 times, most recently from 86e702b to c86ed7a Compare August 14, 2023 19:42
@code-asher code-asher force-pushed the asher/header-process branch from c86ed7a to 958c6c4 Compare August 14, 2023 19:46
@code-asher code-asher merged commit 37f9d4b into main Aug 14, 2023
@code-asher code-asher deleted the asher/header-process branch August 14, 2023 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass headers to coder api
2 participants