Skip to content

fix: update BUILD condition in pr-deploy.yaml #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 13, 2023
Merged

fix: update BUILD condition in pr-deploy.yaml #9064

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c632e1f
fix: update BUILD condition in pr-deploy.yaml
matifali Aug 12, 2023
227e28e
fixup!
matifali Aug 12, 2023
e275df8
update
matifali Aug 13, 2023
588ff73
debug
matifali Aug 13, 2023
196f95a
debug
matifali Aug 13, 2023
8202fc1
testing
matifali Aug 13, 2023
9866ab0
testing
matifali Aug 13, 2023
5c28e36
more tests
matifali Aug 13, 2023
3074bf5
testing
matifali Aug 13, 2023
c01bb8f
testing
matifali Aug 13, 2023
3f6ccc8
more testing
matifali Aug 13, 2023
d0364da
testing
matifali Aug 13, 2023
2a4b888
testing
matifali Aug 13, 2023
4c108c9
testing
matifali Aug 13, 2023
066f3ee
more tests
matifali Aug 13, 2023
ed7744f
testing
matifali Aug 13, 2023
b5ebc20
fixed
matifali Aug 13, 2023
7b5c86b
simplify
matifali Aug 13, 2023
b43924f
always make true or false
matifali Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,7 @@ jobs:
CODER_BASE_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_BASE_IMAGE_TAG }}
CODER_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}
NEW: ${{ steps.check_deployment.outputs.NEW }}
BUILD: |
${{
(steps.filter.outputs.all_count > steps.filter.outputs.ignored_count) &&
(
(github.event_name == 'push' && steps.check_deployment.outputs.NEW == 'false') ||
github.event.inputs.build == 'true'
)
}}
BUILD: ${{ steps.build_conditionals.outputs.first_or_force_build || steps.build_conditionals.outputs.automatic_rebuild }}

runs-on: "ubuntu-latest"
steps:
Expand Down Expand Up @@ -162,18 +155,14 @@ jobs:
echo "Total number of changed files: ${{ steps.filter.outputs.all_count }}"
echo "Number of ignored files: ${{ steps.filter.outputs.ignored_count }}"

- name: Print job outputs
- name: Build conditionals
id: build_conditionals
run: |
set -euo pipefail
# Print all outputs of this job
echo "PR_NUMBER=${{ steps.pr_info.outputs.PR_NUMBER }}"
echo "PR_TITLE=${{ steps.pr_info.outputs.PR_TITLE }}"
echo "PR_URL=${{ steps.pr_info.outputs.PR_URL }}"
echo "CODER_BASE_IMAGE_TAG=${{ steps.set_tags.outputs.CODER_BASE_IMAGE_TAG }}"
echo "CODER_IMAGE_TAG=${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}"
echo "NEW=${{ steps.check_deployment.outputs.NEW }}"
echo "BUILD=${{ (steps.filter.outputs.all_count > steps.filter.outputs.ignored_count) && ((github.event_name == 'push' && steps.check_deployment.outputs.NEW == 'false') || github.event.inputs.build == 'true') }}"
echo "GITHUB_REF=${{ github.ref }}"
# build if the workflow is manually triggered and the deployment doesn't exist (first build or force rebuild)
echo "first_or_force_build=${{ (github.event_name == 'workflow_dispatch' && steps.check_deployment.outputs.NEW == 'true') || github.event.inputs.build == 'true' }}" >> $GITHUB_OUTPUT
# build if the deployment alreday exist and there are changes in the files that we care about (automatic updates)
echo "automatic_rebuild=${{ steps.check_deployment.outputs.NEW == 'false' && steps.filter.outputs.all_count > steps.filter.outputs.ignored_count }}" >> $GITHUB_OUTPUT

comment-pr:
needs: [check_pr, get_info]
Expand Down