Skip to content

docs: explain using Artifactory as a template store #9071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

docs: explain using Artifactory as a template store #9071

merged 1 commit into from
Aug 15, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Aug 13, 2023

docs: explain using Artifactory as a template store

@ammario ammario marked this pull request as draft August 13, 2023 18:12
@ammario ammario force-pushed the pr9071 branch 8 times, most recently from 74dfccd to 54096ce Compare August 15, 2023 20:37
@ammario
Copy link
Member Author

ammario commented Aug 15, 2023

I have the remote template working as of 54096ce. Cleanup and docs next.

@ammario
Copy link
Member Author

ammario commented Aug 15, 2023

Doc content is in good shape as of 86e5480. Need to verify that it lays out well and I'm considering splitting up the modules doc.

@ammario ammario force-pushed the pr9071 branch 3 times, most recently from 1d37b35 to b8407d5 Compare August 15, 2023 21:07
@ammario ammario marked this pull request as ready for review August 15, 2023 21:07
@ammario ammario requested a review from bpmct August 15, 2023 21:10
Comment on lines 117 to 123
```console
# one-time setup commands
terraform login cdr.jfrog.io; jf tfc --global

# jf tf p assumes the module name is the same as the current directory name.
jf tf p --namespace=main --provider=docker --tag=v0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you run this on the Coder server as the coder user?

Let's have an approach for Kubernetes deployments too, such as mounting a config.tfrc file like we do for offline docs, or some type of init container that authenticates. I'm happy to help with this in a separate PR, so let's just make this explicitly clear that you run this on the Coder server not the client,

@ammario ammario merged commit 95d66ac into main Aug 15, 2023
@ammario ammario deleted the pr9071 branch August 15, 2023 21:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants