Skip to content

docs: expand jfrog platform and example template #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 15, 2023
Merged

docs: expand jfrog platform and example template #9073

merged 9 commits into from
Aug 15, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Aug 13, 2023 •
edited
Loading

  1. Updates to use artifactory_scoped_token
  2. Updates the terraform provider
  3. Adds examples for Pypi and Go.
  4. Refactors the template to be usable with other package managers

@matifali matifali requested a review from ammario August 13, 2023 23:15
@matifali matifali changed the title docs: update jfrog package management docs docs: update jfrog package management docs and example template Aug 14, 2023
ammario
ammario approved these changes Aug 14, 2023
View reviewed changes
@matifali matifali enabled auto-merge (squash) August 14, 2023 15:53
@matifali matifali disabled auto-merge August 14, 2023 15:54
@ammario ammario changed the title docs: update jfrog package management docs and example template docs: expand jfrog platform and example template Aug 14, 2023
yinonavraham
yinonavraham reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@yinonavraham yinonavraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Few suggestions, mainly around naming and terminology.

@matifali matifali enabled auto-merge (squash) August 15, 2023 06:59
@matifali matifali merged commit 9a1f845 into main Aug 15, 2023
@matifali matifali deleted the jfrog-pkg-manager-docs branch August 15, 2023 07:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yinonavraham yinonavraham yinonavraham left review comments

@ammario ammario ammario approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @yinonavraham @ammario