fix(scaletest): cleanup: attempt to cancel in-progress jobs #9080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 14, 2023
scaletest/workspacebuild/run.go
Outdated
| if err = r.client.CancelWorkspaceBuild(ctx, build.ID); err != nil { | ||
| logger.Warn(ctx, "failed to cancel workspace build, attempting to delete anyway", slog.Error(err)) | ||
| } else { | ||
| canceled = true |
There was a problem hiding this comment.
We could just wait here vs using a boolean?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to end up in a situation where, after running a
scaletest create-workspaces, you over-estimate your capacity and end up with a bunch of pending workspace builds.It's possible to hack around with this using some
curlandjq, but that's neither ideal nor user-friendly:This change modifies the cleanup behaviour to make a best-effort attempt to cancel the in-progress scaletest workspace build jobs before deleting them.