Skip to content

fix: fix CI concurrency #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

fix: fix CI concurrency #9088

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc0a469
fix: fix concurrency in ci.yaml
matifali Aug 14, 2023
1a16614
Update ci.yaml
matifali Aug 14, 2023
85db987
Update ci.yaml
matifali Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ permissions:
# additional changes
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
cancel-in-progress: ${{ github.event_name == 'push' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cancel pushes on the main branch too? I would expect us to want all pushes to be fully tested there.

Copy link
Member Author

@matifali matifali Aug 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right. It will also cancel on main. May be we should revert #9017

Copy link
Member Author

@matifali matifali Aug 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mafredri Or I can update the condition to ignore main


jobs:
changes:
Expand Down