Skip to content

chore: add oidc sequence diagram image to docs #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 14, 2023

Screenshot from 2023-08-14 10-43-34

@Emyrk Emyrk requested a review from bpmct August 14, 2023 15:45
@bpmct
Copy link
Member

bpmct commented Aug 14, 2023

Hmm I'm not sure if this will work. Any thoughts @BrunoQuaresma?

@BrunoQuaresma
Copy link
Collaborator

I guess relative links work well. An example that I found in the scheduling docs:

![autostop UI](./images/autostop.png)

@bpmct
Copy link
Member

bpmct commented Aug 14, 2023

hmm that is an image though, not a link?

@BrunoQuaresma
Copy link
Collaborator

Ahhh ok 👍 I see Steven fixed that tho. But why not include it as an image instead of an external link to an image? 🤔

@Emyrk
Copy link
Member Author

Emyrk commented Aug 14, 2023

Ahhh ok +1 I see Steven fixed that tho. But why not include it as an image instead of an external link to an image? thinking

I changed it to a link because I don't think the image would work.

And @BrunoQuaresma It's an external link just because we intentionally don't want to embed it in the docs and take up a lot of space. It is a niche request that only a few people will even care about

@Emyrk Emyrk merged commit 6ea82c5 into main Aug 14, 2023
@Emyrk Emyrk deleted the stevenmasley/sequence_diagram_oidc_groups branch August 14, 2023 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants