Skip to content

ci: Enable forks to run CI #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2022
Merged

ci: Enable forks to run CI #910

merged 2 commits into from
Apr 7, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Apr 7, 2022 •
edited
Loading

All steps that require tokens are optional for forks,
and will be skipped if the owner is not "coder".

I also removed the nightly suite that ran. We don't monitor it right now, so I'd rather save the CI spend.

@kylecarbs kylecarbs requested a review from jsjoeio April 7, 2022 01:57
@kylecarbs kylecarbs self-assigned this Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #910 (fde0d77) into main (c1ff537) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   65.57%   65.77%   +0.19%     
==========================================
  Files         216      216              
  Lines       13734    13734              
  Branches      103      103              
==========================================
+ Hits         9006     9033      +27     
+ Misses       3803     3779      -24     
+ Partials      925      922       -3
Flag Coverage Δ
unittest-go- ?
unittest-go-macos-latest 52.67% <ø> (-0.06%) ⬇️
unittest-go-postgres- 65.64% <ø> (?)
unittest-go-ubuntu-latest 55.21% <ø> (-0.04%) ⬇️
unittest-go-windows-2022 52.07% <ø> (-0.09%) ⬇️
unittest-js 58.87% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
peer/conn.go 76.39% <0.00%> (-2.54%) ⬇️
coderd/workspaceresources.go 60.97% <0.00%> (-1.22%) ⬇️
peer/channel.go 83.62% <0.00%> (+0.58%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
provisionerd/provisionerd.go 81.20% <0.00%> (+2.20%) ⬆️
coderd/provisionerdaemons.go 62.05% <0.00%> (+3.03%) ⬆️
peerbroker/proxy.go 61.62% <0.00%> (+3.48%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ff537...fde0d77. Read the comment docs.

@kylecarbs
ci: Enable forks to run CI
514921e 
All steps that require tokens are optional for forks,
and will be skipped if the owner is not "coder".
@kylecarbs kylecarbs force-pushed the forked branch 3 times, most recently from 21469c5 to a9751ca Compare April 7, 2022 02:25
greyscaled
greyscaled reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change, just clarifying what exposing the Chromatic token implies as well as wondering why mac-os is disappearing from the e2e matrix

@greyscaled greyscaled mentioned this pull request Apr 7, 2022
Closed
@kylecarbs kylecarbs merged commit 770d212 into main Apr 7, 2022
@kylecarbs kylecarbs deleted the forked branch April 7, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

@jsjoeio jsjoeio Awaiting requested review from jsjoeio

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @greyscaled