Skip to content

fix: stop inserting provisioner daemons into the database #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

spikecurtis
Copy link
Contributor

fixes #9015

We can revert this and/or reimplement when we have a use case for storing provisioner daemons in the database.

Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with HA too? Multiple coder replicas?

Ah I see the issue it is only used by an api endpoint.

@spikecurtis spikecurtis requested a review from johnstcn August 23, 2023 18:04
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arguably introduces a breaking change into an enterprise feature. What's the path forward for existing consumers of this endpoint?

Even though we only internally use it in unit tests and it's likely not very useful, it's still publicly documented here: https://coder.com/docs/v2/latest/api/enterprise#get-provisioner-daemons

@spikecurtis
Copy link
Contributor Author

This arguably introduces a breaking change into an enterprise feature. What's the path forward for existing consumers of this endpoint?

Even though we only internally use it in unit tests and it's likely not very useful, it's still publicly documented here: https://coder.com/docs/v2/latest/api/enterprise#get-provisioner-daemons

I've left the endpoint in place, so we don't 404. But, I just don't see what anyone could have reasonably used that endpoint for: it's just a big list of every provisioner daemon that ever connected.

maybe @bpmct has thoughts on whether we need to manage this change more carefully.

@spikecurtis
Copy link
Contributor Author

spikecurtis commented Aug 29, 2023

We need to track active provisioner daemons for #5979 so closing this PR and we'll close #9015 when it's fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
@spikecurtis spikecurtis reopened this Sep 8, 2023
@spikecurtis spikecurtis enabled auto-merge (squash) September 8, 2023 10:32
@spikecurtis spikecurtis merged commit 8d7eb17 into main Sep 8, 2023
@spikecurtis spikecurtis deleted the spike/9015-stop-inserting-provisioners branch September 8, 2023 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provisioner_daemons table grows without bounds
3 participants