-
Notifications
You must be signed in to change notification settings - Fork 888
fix: stop inserting provisioner daemons into the database #9108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with HA too? Multiple coder replicas?
Ah I see the issue it is only used by an api endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arguably introduces a breaking change into an enterprise feature. What's the path forward for existing consumers of this endpoint?
Even though we only internally use it in unit tests and it's likely not very useful, it's still publicly documented here: https://coder.com/docs/v2/latest/api/enterprise#get-provisioner-daemons
I've left the endpoint in place, so we don't 404. But, I just don't see what anyone could have reasonably used that endpoint for: it's just a big list of every provisioner daemon that ever connected. maybe @bpmct has thoughts on whether we need to manage this change more carefully. |
…serting-provisioners
fixes #9015
We can revert this and/or reimplement when we have a use case for storing provisioner daemons in the database.