Skip to content

feat: expose Everyone group through UI #9117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 17, 2023
Merged

feat: expose Everyone group through UI #9117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2c7b98d
feat: allow setting quotas on Everyone group
sreya Aug 15, 2023
5a53863
lint
sreya Aug 16, 2023
1d77ffa
pr comments
sreya Aug 16, 2023
f6cf3b7
break
sreya Aug 16, 2023
59db543
port ReadModifyUpdate
sreya Aug 16, 2023
e2da043
redundant check
sreya Aug 16, 2023
3708a4c
pr comments
sreya Aug 17, 2023
13b8689
fix a test
sreya Aug 17, 2023
48b2e3f
lint
sreya Aug 17, 2023
12a6112
fmt
sreya Aug 17, 2023
c6bd4db
gen
sreya Aug 17, 2023
572674b
fix tests
sreya Aug 17, 2023
dddb9ea
fix another test
sreya Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@sreya
sreya committed Aug 17, 2023
commit 572674b147263cfe3c3d3e97dd7557db3ac86f85
2 changes: 1 addition & 1 deletion scripts/develop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ fatal() {
trap 'fatal "Script encountered an error"' ERR

cdroot
start_cmd API "" "${CODER_DEV_SHIM}" server --http-address 0.0.0.0:3000 --swagger-enable --access-url "http://127.0.0.1:3000" --dangerous-allow-cors-requests=true "$@"
start_cmd API "" "${CODER_DEV_SHIM}" server --http-address 0.0.0.0:3000 --swagger-enable --dangerous-allow-cors-requests=true "$@"

echo '== Waiting for Coder to become ready'
# Start the timeout in the background so interrupting this script
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/GroupsPage/GroupPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export const GroupPage: React.FC = () => {
condition={
canUpdateGroup &&
group !== undefined &&
isEveryoneGroup(group)
!isEveryoneGroup(group)
}
>
<AddGroupMember
Expand Down