refactor(coderd): fetch owner information when authorizing workspace agent #9123
Conversation
ae20c36 to
cee1af8
Compare
cee1af8 to
e6ce0f5
Compare
…ndOwnerByAuthToken
| ON | ||
| group_members.user_id = users.id | ||
| WHERE | ||
| -- TODO: we can add more conditions here, such as: |
There was a problem hiding this comment.
nit: out of curiosity, why is it left for later improvement?
There was a problem hiding this comment.
It would change the existing behaviour; right now we just get the agent by the token without further restrictions.
| ON | ||
| workspace_agents.resource_id = workspace_resources.id | ||
| INNER JOIN -- every user is a member of some org | ||
| organization_members |
There was a problem hiding this comment.
I'm curious if we should start testing users being part of 2 organizations.
There was a problem hiding this comment.
TBH I'd honestly defer it until we start having multiple organizations. I'm not sure if we expose multi-orgs at a higher level, or plan to?
There was a problem hiding this comment.
My comment was rather preventing the accumulation of technical debt, but we can leave it for now.
There was a problem hiding this comment.
@mtojek we have quite a bit of the 1 org assumption.
When authorizing a workspace agent, we currently perform a number of queries to
See TODO comment in
getAgentSubject():This PR:
GetWorkspaceAgentByAuthTokento return the owner and associated roles, removing the need for additional queries.Fixes #8065