fix: change oauth convert oidc cookie to SameSite=Lax #9129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strict mode was blocking the cookie from being sent on the redirect flow. This worked on localhost because cookies behave differently on localhost
johnstcn
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strict mode was blocking the cookie from being sent on the redirect flow. This worked on localhost because cookies behave differently on localhost
Closes #9057
Testing on localhost never exercised the bug and was confusing the heck out of me. Thanks @ericpaulsen for the debug environment that reproduced it!
I manually tested this, and unfortunately cannot really exercise this in a unit test. It's browser specific behavior.
The error occurs when you click "Login" on the OIDC portal and you get redirected back to coder. This redirect does not send Strict cookies.