-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: add feature request issue template #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 65.96% 65.98% +0.02%
==========================================
Files 216 216
Lines 13834 13834
Branches 103 103
==========================================
+ Hits 9125 9129 +4
+ Misses 3788 3780 -8
- Partials 921 925 +4
Continue to review full report at Codecov.
|
Co-authored-by: G r e y <grey@coder.com>
Co-authored-by: G r e y <grey@coder.com>
--- | ||
name: Feature request | ||
about: Suggest an idea to improve coder | ||
title: "Enhancement: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have a type: enhancement
label as well, should we name this Feature
to make room for an enhancement template?
Also do we need the prefixes or are the labels enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just consolidate the type: enhancement
applications to this feature one, having both seems unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! @vapurrmaid said the same thing. Updated!
Also do we need the prefixes or are the labels enough?
Probably not but the others have it and I think we should be consistent. So if we change here, we should change on the other templates. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just consolidate
Makes sense to me! I am definitely in favor of that as it is always a headache opening a ticket trying to decide between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think I understood you both right! Let me know if I missed something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh I mean the prefixes in the issues like [Bug]: Fix this bug
and then also tagging with bug
.
I actually quite like the prefixes in the labels personally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do too, but I defer to @misskniss here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely fair. Are we good with making Bug:
, Feat:
, and Docs:
prefixes in issue titles our pattern? @misskniss Or would we rather without?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I say go ahead and merge though if we do end up removing them we can do it separately.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I say go ahead and merge though if we do end up removing them we can do it separately.)
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @jsjoeio 🎉 !
This PR adds a new issue template for feature requests. Feedback welcome!