fix: fix race in PGCoord at startup #9144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a couple of flakes in TestPGCoordinatorDual_Mainline, e.g. https://github.com/coder/coder/actions/runs/5869096650/job/15913511403
I've identified a race condition during the startup of PGCoord that could be responsible.
In PGCoord's querier, we start pubsub subscriptions and workers on separate goroutines. That means that right at startup, we could:
This can only happen if something connects right as we are starting up, which is basically impossible in the field, but happens all the time in our tests.
The fix is to ensure the subscription happens before step 2, so that if an update comes in after 2, we will get notified by our subscription.
I can't be 100% sure this is the cause of the test failures, because we don't have logs that detail the ordering of these events. I've also added better logging so if something like this happens again we can debug.