feat: add force refresh of license entitlements #9155
Conversation
enterprise/coderd/licenses.go
Outdated
| err = api.Pubsub.Publish(PubsubEventLicenses, []byte("refresh")) | ||
| if err != nil { | ||
| api.Logger.Error(context.Background(), "failed to publish forced entitlement update", slog.Error(err)) | ||
| // don't fail the HTTP request, since we did write it successfully to the database |
There was a problem hiding this comment.
I think you should still fail the request if it fails to notify other replicas to update
| <Button | ||
| onClick={() => { | ||
| if (refreshEntitlements) { | ||
| if (refreshEntitlements()) { |
There was a problem hiding this comment.
Why is this in an if?
There was a problem hiding this comment.
If it isn't null, I do not want to call a null function.
There was a problem hiding this comment.
Could you do if (!!refreshEntitlements && refreshEntitlements())
| onClick={() => { | ||
| if (refreshEntitlements) { | ||
| if (refreshEntitlements()) { | ||
| displaySuccess("Successfully refreshed licenses") |
There was a problem hiding this comment.
Sending an event is not a sync operation so does not make too much sense to display this message here. Since you are using XState for that, you could do:
- Call the
refreshEntitlementsfunction - In the refresh button, add a prop
loading={...}
There was a problem hiding this comment.
Hmm, ngl I was not sure exactly how to get this done
There was a problem hiding this comment.
@BrunoQuaresma can I merge this and then we improve it?
Closes #8665
What this does
PubsubEventLicensespubsub to force a new entitlement update on other Coderds. This should update the replica count and remove the warning. This should fix things without any intervention.Abuse prevention
I prevent force refreshing more than once per minute
{ "message":"Entitlements already recently refreshed, please wait 15 seconds to force a new refresh", "detail":"Last refresh at 2023-08-17 20:41:28.89935887 +0000 UTC" }Manual Refresh
@BrunoQuaresma thoughts?
Peek.2023-08-17.16-56.webm