Skip to content

fix: make displayName primary in ParameterLabel component #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 17, 2023

Fixes #6858

Screenshot 2023-08-17 at 3 05 48 PM

@aslilac aslilac requested a review from BrunoQuaresma August 17, 2023 21:07
@aslilac aslilac changed the title fix: displayName should always be primary in ParameterLabel component fix: make displayName primary in ParameterLabel component Aug 17, 2023
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just check if the change looks good on Chromatic.

@aslilac
Copy link
Member Author

aslilac commented Aug 17, 2023

I approved that on accident 💀 a couple of markdown things look wrong, I don't think the paragraph selector is doing what I expected for some reason.

@bpmct
Copy link
Member

bpmct commented Aug 17, 2023

Looks way better!

@aslilac aslilac merged commit 5b165d5 into main Aug 18, 2023
@aslilac aslilac deleted the tweak-parameter-label-style branch August 18, 2023 01:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rich parameters: description appears larger than title
3 participants