Skip to content

feat: Add update profile endpoint #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 12, 2022
Merged

feat: Add update profile endpoint #916

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2bdcaa8
feat: Add UpdateUser to users.sql
BrunoQuaresma Apr 7, 2022
a23c561
feat: Add UpdateUser
BrunoQuaresma Apr 7, 2022
4418d74
feat: add patchUser api endpoint
BrunoQuaresma Apr 7, 2022
27adb09
tests: Add tests
BrunoQuaresma Apr 7, 2022
25a1a7c
fix: format
BrunoQuaresma Apr 7, 2022
dcb9179
refactor: rename user operations to userProfile
BrunoQuaresma Apr 8, 2022
5fe89ba
refactor: use database.Now() instead of CURRENT_TIMESTAMP
BrunoQuaresma Apr 8, 2022
edd8c1f
feat: check if there is a user with the email or username
BrunoQuaresma Apr 8, 2022
d7e749a
refactor: improve invalid error message
BrunoQuaresma Apr 8, 2022
b228896
refactor: improve error
BrunoQuaresma Apr 8, 2022
ae22b4b
fix: rename errors to responseErrors
BrunoQuaresma Apr 8, 2022
1e1fb85
fix: empty name
BrunoQuaresma Apr 8, 2022
c223fcf
refactor: User /profile and make it Update/PUT
BrunoQuaresma Apr 12, 2022
b6eb9f7
fix: lint errors
BrunoQuaresma Apr 12, 2022
7803e8f
style: rename update to put
BrunoQuaresma Apr 12, 2022
4531e0d
fix: Manually update protoc version
BrunoQuaresma Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lint errors
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 12, 2022
commit b6eb9f7281cb7f202ba2db80e62c62adb0559e86
1 change: 0 additions & 1 deletion coderd/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ func (*api) userByName(rw http.ResponseWriter, r *http.Request) {
}

func (api *api) updateUserProfile(rw http.ResponseWriter, r *http.Request) {

user := httpmw.UserParam(r)

var params codersdk.UpdateUserProfileRequest
Expand Down
10 changes: 5 additions & 5 deletions coderd/users_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,13 @@ func TestUpdateUserProfile(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
user := coderdtest.CreateFirstUser(t, client)
existentUser, err := client.CreateUser(context.Background(), codersdk.CreateUserRequest{
existentUser, _ := client.CreateUser(context.Background(), codersdk.CreateUserRequest{
Email: "bruno@coder.com",
Username: "bruno",
Password: "password",
OrganizationID: user.OrganizationID,
})
_, err = client.UpdateUserProfile(context.Background(), codersdk.Me, codersdk.UpdateUserProfileRequest{
_, err := client.UpdateUserProfile(context.Background(), codersdk.Me, codersdk.UpdateUserProfileRequest{
Username: "newusername",
Email: existentUser.Email,
})
Expand All @@ -240,13 +240,13 @@ func TestUpdateUserProfile(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
user := coderdtest.CreateFirstUser(t, client)
existentUser, err := client.CreateUser(context.Background(), codersdk.CreateUserRequest{
existentUser, _ := client.CreateUser(context.Background(), codersdk.CreateUserRequest{
Email: "bruno@coder.com",
Username: "bruno",
Password: "password",
OrganizationID: user.OrganizationID,
})
_, err = client.UpdateUserProfile(context.Background(), codersdk.Me, codersdk.UpdateUserProfileRequest{
_, err := client.UpdateUserProfile(context.Background(), codersdk.Me, codersdk.UpdateUserProfileRequest{
Username: existentUser.Username,
Email: "newemail@coder.com",
})
Expand All @@ -272,7 +272,7 @@ func TestUpdateUserProfile(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
coderdtest.CreateFirstUser(t, client)
me, err := client.User(context.Background(), codersdk.Me)
me, _ := client.User(context.Background(), codersdk.Me)
userProfile, err := client.UpdateUserProfile(context.Background(), codersdk.Me, codersdk.UpdateUserProfileRequest{
Username: me.Username,
Email: "newemail@coder.com",
Expand Down